Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Practice: Add link to Jest Experimental ESM Support #28563

Closed
wants to merge 1 commit into from

Conversation

shonebinu
Copy link
Contributor

@shonebinu shonebinu commented Aug 4, 2024

Because

Jest has experimental support for ES modules. I've done my Testing Practice Project with it. https://github.com/shonebinu/testing-practice

This PR

  • Adds a link to Jest ESM documentation.

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: JavaScript Involves the JavaScript course label Aug 4, 2024
@MaoShizhong
Copy link
Contributor

Going to close this one precisely because the ESM support is experimental. Since it's unstable and subject to change (because it's based around an experimental Node API), I don't think it's sensible to include that in the curriculum yet. If an when it's able to implement stable support, we can then change our lesson material to reflect that.

@MaoShizhong MaoShizhong closed this Aug 4, 2024
@shonebinu
Copy link
Contributor Author

I see.
I included it because, I saw it as the first solution for this problem in StackOverflow. https://stackoverflow.com/questions/68956636/how-to-use-esm-tests-with-jest

But I can understand your judgement, thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: JavaScript Involves the JavaScript course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants