Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic User Interface Interactions: Clarify Image Slider instructions #27716

Conversation

Figby222
Copy link
Contributor

@Figby222 Figby222 commented Mar 30, 2024

Because

The CSS transitions video is important to step 3 of the instructions for the Image Slider exercise.

It was not implied as imperative to the Image Slider exercise to watch the video on transitions,
but it is necessary to step 3 as an introduction to CSS transitions.

This PR

  • Line 9: Clarify that the video demonstrates CSS transitions.
  • Line 42: Reference the transitions video for added clarity.

Issue

Issue not opened.

Additional Information

Initial question:
https://discord.com/channels/505093832157691914/505093832157691916/1212674083263610950

Follow up:
https://discord.com/channels/505093832157691914/505093832157691916/1214749497809182760

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

The CSS transitions video is important to step 3 of the instructions for the Image Slider exercise.

It was not implied as imperative to the Image Slider exercise to watch the video on transitions,
but it is necessary to step 3 as an introduction to CSS transitions.

Changes:
Line 9: Clarify that the video demonstrates CSS transitions.
Line 42: Reference the transitions video for added clarity.
@github-actions github-actions bot added the Content: JavaScript Involves the JavaScript course label Mar 30, 2024
@MaoShizhong
Copy link
Contributor

MaoShizhong commented Mar 30, 2024

Thanks @Figby222 for opening this.

For now, I'm putting this PR on hold as #27247 may result in different required changes.

@MaoShizhong
Copy link
Contributor

Yep, that issue has now been assigned and will result in different changes to this one, so I'll close this one. Thank you still for opening the PR - much appreciated!

@MaoShizhong MaoShizhong closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: JavaScript Involves the JavaScript course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants