14.0 mig l10n it withholding tax #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aturity date [ADD] author [FIX] copyright & description [IMP] l10n_it_withholding_tax - description
[fix] descriptions [fix] dependency [fix] config [fix] config view [fix] using invoice partner in reconcile [imp] using tax authority partner [add] tests first version [imp] tests [imp] tests [ADD] field help [fix] using right date and period when paying
moves all modules into a __unported__ directory
FIX copyright headers FIX PEP8 IMP description IMP description and copyright FIX PEP8
OCA Transbot updated translations from Transifex
Creation of WT statement Wt moves creation Quote for payments
[FIX] 10.0 api compat First beta Travis check Ref name [FIX] Compute WT only if the invoice has wt lines Added feature to unreconcile the wt move created by payment, and after it possible to re-reconcile
[FIX] add display_name on class withholding.tax.move withholding.tax.statement [FIX] add display_name on class withholding.tax.move withholding.tax.statement [FIX] removed select on class l10n_it_withholding_tax l10n_it_withholding_tax_payment [FIX] add README
Disabled delete from tree view of wt statements and wt moves Rates required Disabled delete from tree view of wt statements and wt moves Fix conflicts and changed code with new standards
- Create a USD bank journal - Add 2 rates to USD currency: yesterday with rate 0.8; today with rate 0.9 - Create an USD invoice with date = yesterday - Create a bank statement (on USD bank account) today registering a full payment and try to reconcile Get "Valore di credito o debito errato nella registrazione contabile"
check wt_moves Added rules Show payment move after generation from wt moves More check for payment unreconciliation Company readonly in payment wt Company readonly in payment wt Fix conflict with translation
* [FIX] Travis check and readonly on company_id * [FIX] Travis check and readonly on company_id
odoo/tools/translate.py", line 539, in next
raise Exception("malformed file: bad line: %s" % line)
Exception: malformed file: bad line: # * l10n_it_withholding_tax
Restore l10n_it_withholding_tax_payment/i18n/lt.po
FIX l10n_it_withholding_tax: invoicing user can't open nor create invoices with wh tax
Without the possibility to avoid bank journal, Withholding Tax Statement would appear in Accounting Dashboard / Bank Reconciliation under 'Minus Unreconciled Statement Lines' FIX typo Withhoulding
…is-ci.org/OCA/l10n-italy/jobs/394011315#L2844-L2849 (OCA#517) [FIX] Remove all po files containing duplicate terms (except it.po) in order to get Travis green after weblate migration (OCA#519) The problem was introduced by a manual manipulation of the .po files at OCA@949a109#diff-b06d4f56026a0366ca7fdd91f96ddf27
… date competence equal to payment date (and not invoice date), while date maturity shall be computed based from invoice payment date (OCA#518)
Currently translated at 100.0% (85 of 85 strings) Translation: l10n-italy-10.0/l10n-italy-10.0-l10n_it_withholding_tax Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-10-0/l10n-italy-10-0-l10n_it_withholding_tax/it/
Currently translated at 96.3% (103 of 107 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_withholding_tax Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_withholding_tax/it/
Currently translated at 96.3% (103 of 107 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_withholding_tax Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_withholding_tax/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_withholding_tax Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_withholding_tax/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_withholding_tax Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_withholding_tax/
* [IMP] extend wt_types selection with new code and add tax_id for daticassa * [IMP] use causale_pagamento for all withholding tax type * [IMP] improve wizard_export_fatturapa with new 1.6 xml tack specific
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_withholding_tax Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_withholding_tax/
Currently translated at 94.6% (106 of 112 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_withholding_tax Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_withholding_tax/it/
TheMule71
force-pushed
the
14.0-mig-l10n_it_withholding_tax
branch
from
92bad16
to
548e8fb
Compare
TheMule71
reviewed
May 5, 2021
| @@ -52,9 +52,8 @@ def create(self, vals): | |||
| ml_ids.append(vals.get("credit_move_id")) | |||
| move_lines = self.env["account.move.line"].browse(ml_ids) | |||
| invoice = move_lines.filtered(lambda x: x.exists()).move_id.filtered( | |||
| lambda x: x.is_invoice() | |||
| lambda x: x.withholding_tax | |||
| ) | |||
There was a problem hiding this comment.
Il test su invoice.withholding_tax c'è già sotto.
Qui vanno escluse le account_move che non sono fatture, e bisogna in tal modo dovrebbe rimanere un solo record.
In realtà non fa differenza, il risultato non cambia, alla fine dentro l'if si entra se invoice esiste e ha .witholding_tax
Tuttavia fallisce se - per qualche oscuro motivo - dentro vals finiscono account.move.line che non appartengono ad una fattura ma ad un altro movimento (che non dovrebbe avere comunque .withholding_tax).
TheMule71
pushed a commit
that referenced
this pull request
May 5, 2021
[FIX] l10n_it_reverse_charge: Migration to 14.0 - fix tests and refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
integrazione per la migrazione del modulo l10n_it_withholding_tax
nota: ho commentato una parte nei test perche devo ancora capire come portarle in 14.0 (il resto è ok, risolte le dipendenze)
--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing