-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for [email protected] #6
Comments
Just update all CDVWKWebViewEngine to CDVWebViewEngine, and set the CDVWebViewEngine.h in CordovaLib.xcodeproj from Private to Public |
Hi all, |
Hi @kokitang , please, how did you do that ? Directly in the plugin ? In Xcode ? In my app code ? |
For
You can do it directly in the plugin or in Xcode. and for
You can do this in Xcode, and the changes will lose when reinstall/update the ios platform. |
Thx @kokitang for your answer.
to
in the plugin.xml Then I have to rename both files in src/ios and to edit them ? Thx again. |
@jay34fr E.g. and do it in the same way in other occurrences. |
Thx again ! |
This solution does not work, since it requires cordova-plugin-wkwebview-engine which is no longer supported. https://cordova.apache.org/announcements/2020/06/01/cordova-ios-release-6.0.0.html
Fundamentally this plugin needs to change to toggle the settings: On the native Cordova WKWebView. |
I think the developer is not working on this plugin anymore.... maybe someone will work on a fork one ? |
You are correct - if someone wants to take it over I am happy to transfer.
…On Mon, Jun 29, 2020 at 2:05 PM jay34fr ***@***.***> wrote:
I think the developer is not working on this plugin anymore.... maybe
someone will work on a fork one ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHRYNQH22JH6WMOTHBZ5O3RZDJXDANCNFSM4NQL2AFQ>
.
|
I am working on a fork for this. I am happy to take it on if no one has already. Let me know. |
Thx in advance @lehizojie ! |
How to set the CDVWebViewEngine.h in CordovaLib.xcodeproj from Private to Public? |
@lovelyelfpop You already set it to public |
Here is this one that the guy copied and worked on: https://github.com/globules-io/cordova-plugin-ios-xhr Wish he had forked and submitted a PR but /shrug |
Sorry @TheMattRay, was in a hurry and couldn't adapt your plugin to work . Hence the merge over a new name. If you ever fix this plugin and add
I'll then kill this plugin... Besides, there is none of your original code remaining... |
@globules-io @TheMattRay @kokitang @lehizojie @jay34fr |
Fix for Cordova iOS 6.x.x+
It works fine for me. |
Don’t forget - anyone can submit a PR |
Needs to be updated for new Cordova iOS release!
The text was updated successfully, but these errors were encountered: