feat: Healthz api check appId support

related: dapr/components-contrib#2489 Signed-off-by: AlbertHuang <[email protected]>
TheLandGame · Feb 1, 2023 · 6b29b3e · 6b29b3e
1 parent 4888ae0
commit 6b29b3e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/pkg/http/api.go b/pkg/http/api.go
@@ -475,7 +475,7 @@ func (a *api) constructHealthzEndpoints() []Endpoint {
 	return []Endpoint{
 		{
 			Methods:       []string{fasthttp.MethodGet},
-			Route:         "healthz",
+			Route:         "healthz/{appId:*}",
 			Version:       apiVersionV1,
 			Handler:       a.onGetHealthz,
 			AlwaysAllowed: true,
@@ -2593,7 +2593,13 @@ func (a *api) onGetHealthz(reqCtx *fasthttp.RequestCtx) {
 		respond(reqCtx, withError(fasthttp.StatusInternalServerError, msg))
 		log.Debug(msg)
 	} else {
-		respond(reqCtx, withEmpty())
+		matchAppId := reqCtx.UserValue("appId").(string)
+		if matchAppId != "" && matchAppId != a.id {
+			msg := NewErrorResponse("ERR_HEALTH_APPID_NOT_MATCH", messages.ErrHealthAppIdNotMatch)
+			respond(reqCtx, withError(fasthttp.StatusInternalServerError, msg))
+		} else {
+			respond(reqCtx, withEmpty())
+		}
 	}
 }
 

diff --git a/pkg/messages/api_errors.go b/pkg/messages/api_errors.go
@@ -73,7 +73,8 @@ const (
 	ErrMetadataGet = "failed deserializing metadata: %s"
 
 	// Healthz.
-	ErrHealthNotReady = "dapr is not ready"
+	ErrHealthNotReady      = "dapr is not ready"
+	ErrHealthAppIdNotMatch = "dapr appId is not match"
 
 	// Configuration.
 	ErrConfigurationStoresNotConfigured = "configuration stores not configured"