Add optional timeout #1081
Open
Add optional timeout #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shintasmith
commented
Oct 29, 2024
| @@ -5,9 +5,12 @@ | |||
| # After it's done, port 8682 will be open to facilitate the wait-for and | |||
| # wait-for-it scripts. | |||
| ( | |||
| set -eu | |||
There was a problem hiding this comment.
I have to get rid of this setting because the script will terminate if PUBSUB_EMULATOR_WAIT_TIMEOUT is not defined. I would get the following error:
/run.sh: 11: PUBSUB_EMULATOR_WAIT_TIMEOUT: parameter not set
I was trying to make this new env variable optional so that the behavior is the same as before (it waits only 15s), if the variable is not specified
|
@TheKevJames would you mind reviewing and merging in? Thanks 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to specify timeout for the wait before running
pubsubc, via an optionalPUBSUB_EMULATOR_WAIT_TIMEOUTenvironment variable.The value of this environment variable is passed on to the
/usr/bin/wait-forThis is added to resolve the issue where Google PubSub system takes more than 15s (default timeout for
/usr/bin/wait-for) to be ready.