-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add service number #233
add service number #233
Conversation
Circleci pre-commit failed because of pylint but that is a unrelated to my change.
|
I got the parallel option working with using workflow id as the service num so I'm a bit more confident this is the right approach now: CI Config: # js tests:
- run: yarn test --collectCoverage --coverageDirectory=ff/static/coverage --ci --maxWorkers=3 --reporters=default --reporters=jest-junit
- run: export COVERALLS_PARALLEL=true;yarn coveralls -v < ff/static/coverage/lcov.info
# python tests (runs after js tests)
- run:
name: run tests
command: venv/bin/coverage run --parallel-mode manage.py test --noinput --parallel=4 --verbosity=2
no_output_timeout: 20m
- run: venv/bin/coverage combine
- run: venv/bin/coverage report
- run: export COVERALLS_SERVICE_JOB_NUMBER=$CIRCLE_WORKFLOW_ID;export COVERALLS_PARALLEL=true;venv/bin/coveralls
# coveralls --finish is broken so we need to specify job num
- run: export COVERALLS_SERVICE_JOB_NUMBER=$CIRCLE_WORKFLOW_ID;venv/bin/coveralls --finish |
@TheKevJames sorry about that, I accidentally closed it. In my PR https://github.com/15five/fifteen5/pull/30230 I wrote the following:
Github thought that me saying "fix #233" meant that the PR had been fixed and could be closed 🙄 Too smart for its own good! |
Oh, wow, very weird that Github will close things cross-repos like that -- especially since you made the comment in a private repo and it closed a PR on an OSS repo owned by a completely different Github org. "Too smart for its own good!" no kidding! Anyway, this changeset looks good to me -- I'm just going to wait for an answer on #235 to make sure it works for that case as well, then will merge and released this. Thanks for the contribution! |
I think CIRCLE_WORKFLOW_ID maps to the
number
variable (aka service_number) but I'm not 100% sure.Note that node coveralls uses CIRCLE_WORKFLOW_ID as the service number. See https://github.com/nickmerwin/node-coveralls/blob/705c3b5963e3cc76f8e70381dbae20979008c9b8/lib/getOptions.js#L66