Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Read-only has options to edit task-logs #1334

Closed
crackytsi opened this issue May 14, 2020 · 1 comment
Closed

[Bug] Read-only has options to edit task-logs #1334

crackytsi opened this issue May 14, 2020 · 1 comment
Assignees
Labels
bug TheHive4 TheHive4 related issues
Milestone

Comments

@crackytsi
Copy link

Request Type

Bug

Work Environment

Question Answer
OS version (server) Debian, Ubuntu, CentOS, RedHat, ...
OS version (client) XP, Seven, 10, Ubuntu, ...
TheHive version / git hash 3.x, hash of the commit
Package Type RPM, DEB, Docker, Binary, From source
Browser type & version If applicable

Problem Description

A read-only user can edit the task-logs.
Only if the user wants to store the logs, it failes, using a red error message on the left with the content:
"CaseTaskLog: org.thp.thehive.models.Log not found"

Steps to Reproduce

  1. Create RO user,
  2. Login as RO user
  3. Edit a log entry and save it using ok button.

Possible Solutions

If user has only read-only permission don't give the offer in the GUI to edit a field.
The backend seems to successfully prevent the update because of missing permissions (log message is a little confusing).

@crackytsi crackytsi added TheHive4 TheHive4 related issues bug labels May 14, 2020
@nadouani nadouani self-assigned this May 14, 2020
@nadouani nadouani added this to the 4.0.0-RC3 milestone May 14, 2020
@nadouani
Copy link
Contributor

Thanks @crackytsi for this one, is was tricky to "see" :)

nadouani added a commit that referenced this issue May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug TheHive4 TheHive4 related issues
Projects
None yet
Development

No branches or pull requests

2 participants