This repository has been archived by the owner on Aug 16, 2019. It is now read-only.
update packages #21
Open
update packages #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This looks fine, do you know how we can test to make sure this works correctly? Maybe we load the package into one of the consumers to see if it still works? Maybe there's a more direct way. What's your thought @mikestone14?
There are huge upgrades to a lot of dependencies.
| "lodash": "^4.17.15", | ||
| "normalizr": "^3.4.0", | ||
| "redux-thunk": "^2.3.0", | ||
| "webpack": "^4.37.0" |
There was a problem hiding this comment.
That's a big jump for webpack. How should we test this?
| "eslint-plugin-import": "^2.18.2", | ||
| "eslint-plugin-jsx-a11y": "^6.2.3", | ||
| "eslint-plugin-react": "^7.14.3", | ||
| "expect": "^24.8.0", |
There was a problem hiding this comment.
23 major versions different. Love JS.
|
@admande thanks for tackling this! Long time coming clearly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.