Chore/dev updates #46
Conversation
There was a problem hiding this comment.
this is the only "real" code change in this PR--switching from secure_compare mix package to plug_crypto
mollyretter
force-pushed
the
chore/dev-updates
branch
from
bc88a96 to
dadbaa5
Compare
| @header_key :"X-APIAuth-Content-Hash" | ||
| @md5_header_key :"Content-MD5" | ||
| @value_key :content_hash | ||
| @value_key :content_hash | ||
|
|
There was a problem hiding this comment.
Confirming, because a change in the header type broke us in the past: this is just a formatting change, right?
There was a problem hiding this comment.
yup! just an automated spacing change
| def compare(hc, keys) do | ||
| compare(hc, keys, &SecureCompare.compare/2) | ||
| compare(hc, keys, &Crypto.secure_compare/2) | ||
| end |
There was a problem hiding this comment.
My understanding here: where previously, we were passing in a pointer to &SecureCompare.compare, we've replaced that with &Crypto.secure_compare.
The new lib doesn't require any kind of config args?
There was a problem hiding this comment.
https://elixir-lang.org/getting-started/modules-and-functions.html#function-capturing < here's some more info on the & /2 syntax. both methods have arity of 2 and accept 2 binaries no changes should be needed (but we'll make sure this still works on non-prod)
Description of changes