Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a InstructionValue based on its name #416

Merged
merged 4 commits into from
May 7, 2023

Conversation

Faouzi1406
Copy link
Contributor

Description

Added function to find an Instruction Value based on its name. I thought it was useful for finding instruction values within blocks based on their name. If for example you create a variable, you could use this function to then find it.

Related Issue

#415

How This Has Been Tested

Tested it within my project to retrieve created variables. Also added doc tests.

Checklist

@TheDan64 TheDan64 self-requested a review May 5, 2023 03:22
src/basic_block.rs Outdated Show resolved Hide resolved
src/values/instruction_value.rs Outdated Show resolved Hide resolved
src/basic_block.rs Outdated Show resolved Hide resolved
src/values/instruction_value.rs Outdated Show resolved Hide resolved
@TheDan64
Copy link
Owner

TheDan64 commented May 5, 2023

Also, adding a test would be much appreciated

@Faouzi1406 Faouzi1406 requested a review from TheDan64 May 5, 2023 04:25
@Faouzi1406 Faouzi1406 marked this pull request as draft May 6, 2023 13:17
@Faouzi1406
Copy link
Contributor Author

Hey, is there anything I should change/update?

@Faouzi1406 Faouzi1406 marked this pull request as ready for review May 6, 2023 13:34
Copy link
Owner

@TheDan64 TheDan64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@TheDan64 TheDan64 merged commit 74f0f96 into TheDan64:master May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants