[1/🚀] Ignore single trailing comments on section header lines #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle Rader <[email protected]>
kyle-rader-msft
force-pushed
the
user/kyrader/trailing-comments
branch
from
ea572d5 to
2ced38a
Compare
kyle-rader-msft
changed the title
Merged
TheDaemoness
pushed a commit
that referenced
this pull request
Mar 7, 2024
A small simplification from #6 since the `match` only cares about 1 scenario, an `if let` block can do the same thing in a slightly cleaner way removing the unused match arm. Co-authored-by: Kyle Rader <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #5 in a relatively simple way looking for the last index of matching
]and comment (#, or;) chars. If we find both, and the comment is after the last], then ignore everything after that last comment character.