[ENG-1024] Prevent false alarm from empty campaigns. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottshipman
approved these changes
Aug 26, 2019
ghost
approved these changes
Aug 26, 2019
ghost
reviewed
Aug 26, 2019
| } | ||
| if ($campaignId) { | ||
| return isset($this->publishedCampaignsWithEvents[$campaignId]) ? $this->publishedCampaignsWithEvents[$campaignId] : null; | ||
| } else { |
There was a problem hiding this comment.
This else statement isn't needed, just my preference though.
There was a problem hiding this comment.
agreed, next time I'm in there I'll clean up. This was copy pasta.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure you are submitting this against the master branch.
//: # This Pull Request (Place an 'X' for each):
Description:
Just prevents alerts when there's a delay for campaigns due to the fact that there are no events in the campaign, as that's expected behavior.