Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-619] Base health checks on time instead of quantity. #3

Merged
merged 9 commits into from
Feb 20, 2019
Merged

[ENG-619] Base health checks on time instead of quantity. #3

merged 9 commits into from
Feb 20, 2019

Conversation

heathdutton
Copy link
Member

This is way saver, and about 1000x faster.
Only checks kickoff events and scheduled events, but well worth the
change.

scottshipman
scottshipman suggested changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@scottshipman scottshipman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment - initalize $data as array in DashboardSubscriber

@scottshipman scottshipman merged commit c9b3f9c into master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottshipman scottshipman scottshipman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heathdutton @scottshipman