Skip to content

Commit

Permalink
(chocolatey#1764) source exit 2 if nothing to do
Browse files Browse the repository at this point in the history
If enhanced exit codes are enabled, this sets the source command to
exit with 2 if there is nothing to do (i.e. if NOCHANGEMESSAGE is
output).
  • Loading branch information
TheCakeIsNaOH authored and gep13 committed Apr 23, 2024
1 parent ce5cf64 commit 8c4f987
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -164,12 +164,17 @@ Exit codes that normally result from running this command.
Normal:
- 0: operation was successful, no issues detected
- -1 or 1: an error has occurred
- 2: nothing to do (enhanced)
NOTE: Starting in v2.3.0, if you have the feature '{0}'
turned on, then choco will provide enhanced exit codes that allow
better integration and scripting.
If you find other exit codes that we have not yet documented, please
file a ticket so we can document it at
https://github.com/chocolatey/choco/issues/new/choose.
");
".FormatWith(ApplicationParameters.Features.UseEnhancedExitCodes));

"chocolatey".Log().Info(ChocolateyLoggers.Important, "Options and Switches");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,11 @@ public void AddSource(ChocolateyConfiguration configuration)
{
this.Log().Warn(NoChangeMessage);
}

if (configuration.Features.UseEnhancedExitCodes && Environment.ExitCode == 0)
{
Environment.ExitCode = 2;
}
}
else
{
Expand Down Expand Up @@ -201,6 +206,11 @@ public void RemoveSource(ChocolateyConfiguration configuration)
{
this.Log().Warn(NoChangeMessage);
}

if (configuration.Features.UseEnhancedExitCodes && Environment.ExitCode == 0)
{
Environment.ExitCode = 2;
}
}
}

Expand All @@ -222,6 +232,11 @@ public void DisableSource(ChocolateyConfiguration configuration)
{
this.Log().Warn(NoChangeMessage);
}

if (configuration.Features.UseEnhancedExitCodes && Environment.ExitCode == 0)
{
Environment.ExitCode = 2;
}
}
}

Expand All @@ -243,6 +258,11 @@ public void EnableSource(ChocolateyConfiguration configuration)
{
this.Log().Warn(NoChangeMessage);
}

if (configuration.Features.UseEnhancedExitCodes && Environment.ExitCode == 0)
{
Environment.ExitCode = 2;
}
}
}

Expand Down

0 comments on commit 8c4f987

Please sign in to comment.