Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor validator performance #37

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

meilisss
Copy link
Collaborator

@meilisss meilisss commented Oct 13, 2022

Copy link
Collaborator

@barwareng barwareng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Fix performance calculation as noted
  2. Update the codebase to remove all instances of Validator update queue - make sure it builds before creating the PR.


bidValidators.push({
publicKey: bid.public_key,
numOfDelegators: bid?.bid?.delegators?.length,
delegationRate: bid.bid?.delegation_rate,
performance: eraValidatorsInfo.length / 360,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validator performance calculation is incorrect - refer to the previous implementation and make it a bid by bid case not all bids per era.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants