Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Shor Algorithm #6067

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

joelkurien
Copy link

@joelkurien joelkurien commented Oct 30, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 65.51724% with 10 lines in your changes missing coverage. Please review.

Project coverage is 73.41%. Comparing base (03bb8ee) to head (85f3582).

Files with missing lines Patch % Lines
...n/java/com/thealgorithms/others/ShorAlgorithm.java 65.51% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6067      +/-   ##
============================================
- Coverage     73.42%   73.41%   -0.02%     
- Complexity     5078     5084       +6     
============================================
  Files           656      657       +1     
  Lines         17617    17646      +29     
  Branches       3394     3400       +6     
============================================
+ Hits          12936    12954      +18     
- Misses         4180     4188       +8     
- Partials        501      504       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add JUnit tests and remove printing to console

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good, please fix PR checks

@Chiefpatwal
Copy link
Contributor

@siriak can i work on this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants