Merge sort added more efficient #1294
Conversation
BamaCharanChhandogi
requested review from
Panquesito7,
tjgurwara99 and
alexpantyukhin
as code owners
|
Hey! @alexpantyukhin can you check? |
| * @param [in,out] b pointer to second variable | ||
| */ | ||
| void swap(int *a, int *b) | ||
| // Function to merge two sorted subarrays into one sorted array |
There was a problem hiding this comment.
why have you decreased the documentation please restore the old documentation
There was a problem hiding this comment.
I have removed the documentation of the "swap" function. because here I don't use the Swap function. so why I write documentation if it! I wrote more efficient code.
There was a problem hiding this comment.
Understood! Sorry for the confusion.
There was a problem hiding this comment.
Understood! Sorry for the confusion.
| } | ||
|
|
||
| /** Merge sort algorithm implementation | ||
| * @param a array to sort | ||
| * @param n number of elements in the array |
There was a problem hiding this comment.
this style of documentation was prefered
There was a problem hiding this comment.
I have added these portions.
sorting/merge_sort.c
Outdated
| */ | ||
| void merge_sort(int *a, int n, int l, int r) | ||
| // Merge sort function | ||
| void mergeSort(int arr[], int left, int right) |
There was a problem hiding this comment.
i think we use snake_case for all things naming
|
I have added documentation, I think no more need. |
sorting/merge_sort.c
Outdated
|
|
||
| /** Main function */ | ||
| int main(void) | ||
| int main() |
There was a problem hiding this comment.
| int main() | |
| /** | |
| * @brief main function | |
| * @returns 0 on successful exit | |
| */ | |
| int main() |
There was a problem hiding this comment.
I added comment before main function.
sorting/merge_sort.c
Outdated
| printf("Original array: "); | ||
| for (int i = 0; i < n; i++) printf("%d ", arr[i]); | ||
|
|
||
| merge_sort(arr, 0, n - 1); |
There was a problem hiding this comment.
Please make a separate function for all the testing!
I am not that well read on c but if there is a static keyword please use that as well
static void tests(){
// tests here
}There was a problem hiding this comment.
I have added the test function.
| */ | ||
| #include <assert.h> |
There was a problem hiding this comment.
these need to be documented as well
#include <header.h> /// <reason for header.h>
Description of Change
References
Checklist
Notes: