gpl: the pin location for instance not in R0/N is wrong #6249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
Pin::updateCoordi ignored instance orientation. This caused instances to be pull towards the wrong edge of macros not in R0/N. Signed-off-by: Matt Liberty <[email protected]>
Signed-off-by: Matt Liberty <[email protected]>
openroad-robot
force-pushed
the
gpl-orient-bug
branch
from
10a5df2
to
e0399de
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
secure ci running |
maliberty
approved these changes
Nov 27, 2024
maliberty
added a commit
to The-OpenROAD-Project/OpenROAD-flow-scripts
that referenced
this pull request
Nov 27, 2024
…l-orient-bug Update metrics for gpl-orient-bug (The-OpenROAD-Project/OpenROAD#6249)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin::updateCoordi ignored instance orientation. This caused instances to be pull towards the wrong edge of macros not in R0/N.