Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nangate45/ariane136 place density and metrics #2592

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

gudeh
Copy link
Contributor

@gudeh gudeh commented Nov 26, 2024

Nightly is failing on this design after gpl integration with rsz repair_design. For this specific situation, it never converges, the overflow diverges up and down. With the increased density it converges as expected.

I understand the issue is happening because rsz does a substantial increase in area and gpl is currently unable to find a solution with a lower density. After we increase the area, there is less empty space and we are unable to reach the target density.

./designs/nangate45/ariane136/ --variant base --failing --tighten

Metric Old New Type
finish__timing__drv__hold_violation_count 835 259 Tighten

@maliberty
Copy link
Member

Sounds like the same as The-OpenROAD-Project/OpenROAD#6238. We can merge this to get master passing but should revisit after fixing that issue.

@gudeh
Copy link
Contributor Author

gudeh commented Nov 26, 2024

The two issues indeed are really similar but with a difference. GPL has fillercells which relate to the empty space available. On Peter's issue the filler cell area ends up being negative, meaning it is impossible to achieve the target density.

This one from Ariane the issue is more hidden, because there should be empty space available, but the algorithm itself could not find a solution.

Either way, I must find a solution for this.

@maliberty
Copy link
Member

@gadfort why are there filler cells at global placement?

@gadfort
Copy link
Contributor

gadfort commented Nov 26, 2024

@gadfort why are there filler cells at global placement?

@maliberty I think @gudeh is referring to the "filler cells" that GPL uses, not actual filler cells. (answered in the wrong place)

@gudeh
Copy link
Contributor Author

gudeh commented Nov 26, 2024

yes, GPL has some unusual namings. Its filler cells are just "dummy" cells to occupy any empty space. I understand they influence the movement of real cells.

@maliberty maliberty merged commit 84cc887 into The-OpenROAD-Project:master Nov 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants