ihp-sg32g2: update pdn.tcl to connect IO pads by default #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Henkes <[email protected]>
maliberty
reviewed
Oct 31, 2024
Comment on lines
26
to
+30
| add_pdn_connect -grid {grid} -layers {Metal1 Metal5} | ||
| add_pdn_connect -grid {grid} -layers {Metal5 TopMetal1} | ||
| # I/O pads | ||
| add_pdn_connect -grid {grid} -layers {Metal5 TopMetal2} | ||
| add_pdn_connect -grid {grid} -layers {TopMetal1 TopMetal2} |
There was a problem hiding this comment.
@gadfort does this look right? There seems to be some redundancy.
There was a problem hiding this comment.
It's a bit unusual since the I/O cells connect on TM2, the top-most layer, in both directions, disregarding the layer's routing direction and making it impossible to via upwards first.
Here are two screenshots comparing the results with and without the M5 <-> TM2 connection:
With:
Without:
The difference is a little weird. Without the connection, there are far fewer but not zero horizontal connections.
maliberty
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IHP's new I/O pads connect power on TopMetal2 with pins called "vdd" and "vss". This change adds the pin names and the necessary layer connections to
pdn.tclsuch that the I/O pads connect to the PDN by default.