Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old mpl/tdms flow now that mpl2 is the default. #2513

Conversation

openroad-robot
Copy link
Contributor

Prep to remove mpl.

Prep to remove mpl.

Signed-off-by: Matt Liberty <[email protected]>
@maliberty
Copy link
Member

@oharboe @jeffng-or hopefully this doesn't affect bazel-orfs but I hope you'll take care of it as needed. I'm dropping the tdms step and the old macro placer.

@maliberty
Copy link
Member

secure-ci passed

@maliberty maliberty merged commit b2a0693 into The-OpenROAD-Project:master Oct 28, 2024
6 checks passed
@maliberty maliberty deleted the rm-tmds-mpl branch October 28, 2024 17:11
@oharboe
Copy link
Collaborator

oharboe commented Oct 28, 2024

@oharboe @jeffng-or hopefully this doesn't affect bazel-orfs but I hope you'll take care of it as needed. I'm dropping the tdms step and the old macro placer.

Just like variables.yaml, we're lacking a stages.yaml file, so this information is maintained manually in bazel-orfs now. Will take care of it.

@maliberty
Copy link
Member

Stages change very slowly so I'm not sure it is worth automation.

@oharboe
Copy link
Collaborator

oharboe commented Oct 28, 2024

Stages change very slowly so I'm not sure it is worth automation.

That has been my experience. I've tweaked it a few times and we have a bunch of CI bazel-orfs regression tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants