global route: fix GENERATE_ARTIFACTS_ON_FAILURE use-case #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the .sdc file must be written out alongside the .odb file and .rpt file in the failing test case when GENERATE_ARTIFACTS_ON_FAILURE=1 Signed-off-by: Øyvind Harboe <[email protected]>
maliberty
reviewed
Oct 27, 2024
flow/scripts/global_route.tcl
Outdated
Comment on lines
31
to
34
| if {[expr !$::env(GENERATE_ARTIFACTS_ON_FAILURE) || \ | ||
| ![file exists $::global_route_congestion_report] || \ | ||
| [file size $::global_route_congestion_report] == 0]} { | ||
| write_sdc -no_timestamp $::env(RESULTS_DIR)/5_1_grt.sdc |
There was a problem hiding this comment.
Why is this in the !$::env(GENERATE_ARTIFACTS_ON_FAILURE) branch? You said you want it for GENERATE_ARTIFACTS_ON_FAILURE=1
There was a problem hiding this comment.
Failing eyesight, will fix
There was a problem hiding this comment.
Fixed.
I wish there was an easy and robust way to induce a global route failure in one of the ORFS designs...
the .sdc file must be written out alongside the .odb file and .rpt file in the failing test case when GENERATE_ARTIFACTS_ON_FAILURE=1 Signed-off-by: Øyvind Harboe <[email protected]>
maliberty
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the .sdc file must be written out alongside the .odb file and .rpt file in the failing test case whenGENERATE_ARTIFACTS_ON_FAILURE=1.
I suppose copying would have worked too, but write_sdc should be fine.