floorplan: use 2_floorplan.sdc in floorplan, written by floorplan.tcl #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since floorplan.tcl can do retiming, it is important to use post retiming .sdc file in subsequent steps to avoid incorrect timing information fixes The-OpenROAD-Project#2485 Signed-off-by: Øyvind Harboe <[email protected]>
oharboe
changed the title
|
@maliberty When should a new .sdc file be written out and when should it be used? I thought that a new .sdc file should be written out and used after repair_timing_helper, in which case global_route.tcl also needs to write out a .sdc file, which should be used in detailed routing + fillcell.tcl |
Since global route can run timing repair, it must write out an .sdc file and it must be used going forward. Signed-off-by: Øyvind Harboe <[email protected]>
oharboe
changed the title
|
@maliberty pr-head works, pr-merge has unrelated autotuner instabilities. |
maliberty
approved these changes
Oct 21, 2024
It does repair_timing not retiming. Currently that has no effect on sdc but this change doesn't hurt for future proofing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since floorplan.tcl can do retiming, it is important to use post retiming .sdc file in subsequent steps to avoid incorrect timing information.
Note that loading 1_synth.sdc would appear to work in the case that the SDC_FILE is using patterns, rather than specific names written out longhand in 2_floorplan.sdc.
fixes #2485