✨ Add a plot component to the Radial theme #12
Conversation
BattleCh1cken
changed the title
BattleCh1cken
requested review from
dblaufuss,
RubyflameWarrior and
BestUsernamEver
BattleCh1cken
force-pushed
the
feature-plot
branch
from
85dd715 to
37dd3d3
Compare
|
Message to reviewers: review #13 before reviewing this. |
|
|
||
| plot.plot( | ||
| name: "plot", | ||
| plot-style: plot-style, |
There was a problem hiding this comment.
not a huge issue, but as it is I don't really think the stoke used in the grid looks good. It creates a lot of weird overlaps and looks a little messy, if possible could you change it to something like this:
stroke: (dash: none, thickness: .2pt, paint: black)
(This is the same grid style I used in the gantt chart, maybe we should use some sort of consistent grid style for charts)
There was a problem hiding this comment.
Alright, I'll look into it.
themes/radial/components/graphs.typ
Outdated
| #let plot( | ||
| title: "", | ||
| x-label: "", | ||
| y-label: "", |
There was a problem hiding this comment.
maybe add a way to change the variables so it's not always x and y, but just have it so those are defaults? like if I'm plotting a velocity time graph, it would make sense to have v and t axis
There was a problem hiding this comment.
The API is meant to be as simple as possible. If people want something more advanced they can just use the underlying library.
(also I have no idea how to do this)
| import cetz.palette | ||
|
|
||
| // Style for the data lines | ||
| let plot-colors = (blue, red, green, yellow, pink, orange) |
There was a problem hiding this comment.
Boo no rainbow order
let plot-colors = (red, orange, yellow, green, blue, pink)
Summary
This feature adds a basic wrapper around Cetz's plotting library with a relatively simple API.
Checklist