Feature add etrd stat tracking #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I initially implemented this terminal tracking I decided not to implement this because we already have the variant EnergyTerminalSentDomestic, which should encapsulate all transfers that are also EnergyTerminalReceivedDomestic? I don't see why this is useful, unless I am incorrect |
|
well i find it useful because now you can see where the domestic energy is going to. Because the other stat is outgoing from a room but you had no idea where it was going to
|
|
Ahh good point, useful for debugging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tracking of a new stat for EnergyTerminalReceivedDomestic (etrd) for rooms receiving domestic energy transfers from terminals