Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

placed </div> at line 221 #42

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

placed </div> at line 221 #42

wants to merge 3 commits into from

Conversation

rajchordia14
Copy link

update index.html

@rajchordia14 rajchordia14 mentioned this pull request Jun 18, 2020
Closed
@tushar5526
Copy link
Member

No, you fixed the wrong tag. See the "span" tag on 221 :) @rajchordia14

tushar5526
tushar5526 reviewed Jun 19, 2020
View reviewed changes
index.html
</div>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this extra new line

@tushar5526
Copy link
Member

tushar5526 commented Jun 19, 2020 •
edited
Loading

Its not good practice to use master branch to make changes. We leave master branch untouched and then make a new branch to work on new features . git checkout -b <your branch name>
Read the README.md of this repo
Its better to have only one commit for such small errors, you can use git squash to combine those 3 commits into one. Then force push the branch back to remote git push origin <branch-name>

tushar5526
tushar5526 requested changes Jun 19, 2020
View reviewed changes
Copy link
Member

@tushar5526 tushar5526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the changes please :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tushar5526 tushar5526 tushar5526 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajchordia14 @tushar5526