Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first commit #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

first commit #9

wants to merge 1 commit into from

Conversation

Anutosh21
Copy link

Thanks .

adiaholic
adiaholic requested changes Jun 16, 2020
View reviewed changes
Copy link
Member

@adiaholic adiaholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never use ambiguous branch name to make PRs. Instead you should make a branch on your fork: eg Ashutosh21/hello-world. If you make PRs from ambiguous branches, you won't be able to understand what that branch does without taking a look into it. And this is really painful from the reviewers POV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adiaholic adiaholic adiaholic requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anutosh21 @adiaholic