Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue #534 #557

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Fixing issue #534 #557

merged 1 commit into from
Jan 25, 2021

Conversation

asharonbaltazar
Copy link
Contributor

@asharonbaltazar asharonbaltazar commented Jan 25, 2021

I copied styles and applied them to the Partner list items to maintain consistency. The items now animate on hover.

Sidenote: I had to add --no-verify to my git command to bypass testing. What should I do there?

Edit: concerning issue #534

@vercel
Copy link

vercel bot commented Jan 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/that-conference/thatus/pwuq0e0zu
✅ Preview: https://thatus-git-fork-asharonbaltazar-issue-534-partner-animation.that-conference.now.sh

@theClarkSell
Copy link
Member

@asharonbaltazar what wasn't working about the verification?

@theClarkSell
Copy link
Member

Closes issue #534

@asharonbaltazar
Copy link
Contributor Author

I can't even screenshot it because the console in VS can't scroll that far up... Basically a bunch of errors from some testing/linting?

@theClarkSell
Copy link
Member

Interesting.. Well that should have failed the build here if it was an issue. let's bring this to a discussion so we can get to the root. #558

@theClarkSell theClarkSell merged commit 35c5c42 into ThatConference:master Jan 25, 2021
@asharonbaltazar
Copy link
Contributor Author

This should probably have a separate thread. I'll try and get a screenshot with my next PR. I'm closing this thread then.

@asharonbaltazar asharonbaltazar deleted the issue-534-partner-animation branch January 25, 2021 17:34
@theClarkSell
Copy link
Member

I created a discussion thread about it here -#558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants