fix: removed old open attribute and added targetBlank

ThatConference · Aug 10, 2022 · d90d983 · d90d983
1 parent f876842
commit d90d983
Show file tree

Hide file tree

Showing 11 changed files with 8 additions and 18 deletions.
diff --git a/src/_components/activities/ActivityDetails.svelte b/src/_components/activities/ActivityDetails.svelte
@@ -197,7 +197,7 @@
 					{#each speakers as s}
 						<div class="flex flex-col items-center md:flex-row">
 							<div class="flex-shrink-0">
-								<a href="/members/{s.profileSlug}/" open>
+								<a href="/members/{s.profileSlug}/">
 									<span class="relative inline-block">
 										<img
 											class="lazyload h-24 w-24 rounded-full"
@@ -479,7 +479,7 @@
 										<Icon data={externalLink} class="h-4 w-4" />
 									</div>
 									<div class="flex-grow rounded-md p-2">
-										<a open rel="external" href={sa.url}>
+										<a target="_blank" rel="external" href={sa.url}>
 											<p>{sa.name}</p>
 											<p class="mt-1 text-sm text-gray-400">{sa.description}</p>
 										</a>

diff --git a/src/_components/activities/Card.svelte b/src/_components/activities/Card.svelte
@@ -349,7 +349,7 @@
 			</div>
 		{/if}
 		<div class="flex w-full flex-col items-center p-3">
-			<a sveltekit:prefetch open href="/members/{host.profileSlug}/" class="flex-shrink-0">
+			<a sveltekit:prefetch href="/members/{host.profileSlug}/" class="flex-shrink-0">
 				<span class="relative inline-block">
 					<img
 						class="lazyload h-24 w-24 rounded-full"

diff --git a/src/_components/activities/KeynoteCard.svelte b/src/_components/activities/KeynoteCard.svelte
@@ -70,7 +70,6 @@
 								{#if location === 'THAT'}
 									<div class="m-3 inline-flex rounded-md shadow-md">
 										<a
-											open
 											href={`/join/${id}`}
 											class="focus:ring-red relative inline-flex w-32
                       items-center justify-center rounded-md border border-gray-300 bg-white
@@ -85,7 +84,6 @@
 								{:else}
 									<div class="m-3 inline-flex rounded-md shadow-md">
 										<a
-											open
 											href="https://youtube.com/c/thatconference"
 											class="focus:ring-red relative inline-flex w-32
                       items-center justify-center rounded-md border border-gray-300 bg-white

diff --git a/src/_components/events/layouts/hybrid/nav/components/navLink.svelte b/src/_components/events/layouts/hybrid/nav/components/navLink.svelte
@@ -6,7 +6,6 @@
 	<a
 		sveltekit:prefetch
 		{href}
-		open
 		class="w-full rounded-md px-3 py-2 text-gray-600
 			transition duration-150 ease-in-out 
 		hover:bg-that-blue hover:text-white

diff --git a/src/_components/nav/interiorNav/Large.svelte b/src/_components/nav/interiorNav/Large.svelte
@@ -36,7 +36,6 @@
 			<a
 				sveltekit:prefetch
 				href="/events/"
-				open
 				class="ml-1 rounded-md px-3 py-2 text-sm font-medium text-gray-300
           hover:bg-that-blue hover:text-white focus:bg-that-blue
           focus:text-white focus:outline-none">
@@ -45,7 +44,6 @@
 
 			<a
 				sveltekit:prefetch
-				open
 				href="/activities/"
 				class="ml-1 rounded-md px-3 py-2 text-sm font-medium text-gray-300
           hover:bg-that-blue hover:text-white focus:bg-that-blue

diff --git a/src/_components/social/SocialLink.svelte b/src/_components/social/SocialLink.svelte
@@ -59,7 +59,7 @@
 	}
 </script>
 
-<a {href} aria-label={ariaLabel} target="_blank" rel="noopener">
+<a {href} aria-label={ariaLabel} target="_blank">
 	<Icon
 		data={socialIcon}
 		class={`transform cursor-pointer transition duration-500 ease-in-out hover:scale-125 ${

diff --git a/src/routes/activities/_components/form/components/_AdditionalResources.svelte b/src/routes/activities/_components/form/components/_AdditionalResources.svelte
@@ -122,7 +122,7 @@
 				<li class="pt-4">
 					<div class="flex items-center space-x-4">
 						<div class="flex-grow rounded-md p-2" class:bg-gray-50={showBackground(i)}>
-							<a open href={item.url}>
+							<a target="_blank" href={item.url}>
 								<p>{item.name}</p>
 								<p class="mt-1 text-sm text-gray-400">{item.description}</p>
 							</a>

diff --git a/src/routes/my/profiles/_components/profileForm.svelte b/src/routes/my/profiles/_components/profileForm.svelte
@@ -677,7 +677,6 @@
 									<div class="ml-3 text-sm leading-5">
 										<label for="comments" class="font-medium text-gray-700">
 											<a
-												open
 												tabindex="-1"
 												href="/support/code-of-conduct/"
 												class="font-medium text-indigo-600 transition
@@ -708,7 +707,6 @@
 										<div class="ml-3 text-sm leading-5">
 											<label for="comments" class="font-medium text-gray-700">
 												<a
-													open
 													tabindex="-1"
 													href="/suppoprt/anti-harassment/"
 													class="font-medium text-indigo-600 transition
@@ -738,7 +736,6 @@
 											<div class="ml-3 text-sm leading-5">
 												<label for="comments" class="font-medium text-gray-700">
 													<a
-														open
 														tabindex="-1"
 														href="/support/commitment-to-diversity/"
 														class="font-medium text-indigo-600
@@ -772,7 +769,6 @@
 												<div class="ml-3 text-sm leading-5">
 													<label for="candidates" class="font-medium text-gray-700">
 														<a
-															open
 															tabindex="-1"
 															href="/support/terms-of-use/"
 															class="font-medium text-indigo-600
@@ -846,7 +842,6 @@
 										<label for="comments" class="font-medium text-gray-700">
 											<a
 												tabindex="-1"
-												open
 												href="/support/code-of-conduct/"
 												class="font-medium text-indigo-600 transition
                         duration-150 ease-in-out hover:text-indigo-500">

diff --git a/src/routes/partners/_components/_EventPartnerLevel.svelte b/src/routes/partners/_components/_EventPartnerLevel.svelte
@@ -15,7 +15,7 @@
 			{#each partners as p, i (p.id)}
 				<li
 					class="col-span-1 flex transform flex-col rounded-lg bg-white text-center shadow transition duration-500 ease-in-out hover:scale-105 hover:bg-that-offWhite">
-					<a open href={`/partners/${p.slug}`}>
+					<a href={`/partners/${p.slug}`}>
 						<PartnerCard {...p} />
 					</a>
 				</li>

diff --git a/src/routes/partners/index.svelte b/src/routes/partners/index.svelte
@@ -52,7 +52,7 @@
 						{#each partners as p, i (p.id)}
 							<li
 								class="col-span-1 flex transform flex-col rounded-lg bg-white text-center shadow transition duration-500 ease-in-out hover:scale-105 hover:bg-that-offWhite">
-								<a open href={`/partners/${p.slug}`}>
+								<a href={`/partners/${p.slug}`}>
 									<PartnerCard {...p} />
 								</a>
 							</li>

diff --git a/src/routes/partners/past/index.svelte b/src/routes/partners/past/index.svelte
@@ -50,7 +50,7 @@
 						{#each partners as p, i (p.id)}
 							<li
 								class="col-span-1 flex transform flex-col rounded-lg bg-white text-center shadow transition duration-500 ease-in-out hover:scale-105 hover:bg-that-offWhite">
-								<a open href={`/partners/${p.slug}`}>
+								<a href={`/partners/${p.slug}`}>
 									<PartnerCard {...p} />
 								</a>
 							</li>