Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCE] Types Enhancement #9

Merged
merged 3 commits into from
Apr 3, 2021

Conversation

anthlasserre
Copy link
Contributor

Enhance the npm package with a type compatiblity that can be useful when using this package on a TypeScript project.
Open to update or suggestions to enhance this PR.

@Thanasis1101
Copy link
Owner

Thanasis1101 commented Apr 1, 2021

@anthlasserre that's great work ! Thanks for improving the package !
Since I don't have experience with typescript, I would appreciate it if you could confirm that this works fine in a typescript project and that it does not effect anything already working, so that I can accept and publish your changes.
Also feel free to add a folder with an example typescript project (like the /example folder but for typescript) if you have one and you think would be useful.

@anthlasserre
Copy link
Contributor Author

@Thanasis1101 Hey mate! We use in my company this package on two projects. This is normal. That is the least we can do to contribute and enhance together this package.

Yes I will investigate more in details if it's working fine and I will comme back to you with a typescript project example.

@Thanasis1101 Thanasis1101 added the enhancement New feature or request label Apr 1, 2021
@anthlasserre
Copy link
Contributor Author

@Thanasis1101 Will this example be right for you?
ts-gif-search-example

@anthlasserre
Copy link
Contributor Author

@Thanasis1101 I've tested and it works

@Thanasis1101 Thanasis1101 merged commit 46a83e4 into Thanasis1101:master Apr 3, 2021
@Thanasis1101
Copy link
Owner

@anthlasserre Awesome work ! I saw and tested you changes and uploaded v1.3.0 !

I also updated the main README.md and added a new README for each example(JS README and TS README), while giving you credit for the TypeScript support.

I am glad for the cooperation ! Let's keep up the good work !

@anthlasserre anthlasserre deleted the enhance/types-enhancement branch April 6, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants