Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibreSSL does not support EVP_DigestSign and EVP_DigestVerify #100

Closed
Thalhammer opened this issue Sep 10, 2020 · 0 comments · Fixed by #105
Closed

LibreSSL does not support EVP_DigestSign and EVP_DigestVerify #100

Thalhammer opened this issue Sep 10, 2020 · 0 comments · Fixed by #105
Labels
bug

Comments

@Thalhammer
Copy link
Owner

Thalhammer commented Sep 10, 2020 •
edited
Loading

The new EdDSA support uses calls to EVP_DigestSign/EVP_DigestVerify which are not supported by LibreSSL.
We dont officialy support LibreSSL but since it seems to otherwise compile fine and its an pretty easy fix I think we should remove calls to those convenience functions and use EVP_DigestSignInit and EVP_DigestSignFinal instead.
We might also consider adding a ci test to make sure everything actually works with libressl as it should.
@Thalhammer Thalhammer added the bug label Sep 10, 2020
@Thalhammer Thalhammer mentioned this issue Oct 25, 2020
Closed
@Thalhammer Thalhammer changed the title LibreSSL does not support EVP_DigestSign and EVP_DigestSign LibreSSL does not support EVP_DigestSign and EVP_DigestVerify Oct 25, 2020
Thalhammer added a commit that referenced this issue Oct 25, 2020
@Thalhammer
Attempt to fix issue #100 and #99
782acc0
@Thalhammer Thalhammer mentioned this issue Oct 26, 2020
Merged
Thalhammer added a commit that referenced this issue Oct 26, 2020
@Thalhammer @prince-chrismc
Fix issue #100 and #99 (#105)
0ebf4f1 
Co-authored-by: Chris Mc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #100 and #99 Thalhammer/jwt-cpp
1 participant
@Thalhammer