Aim Bug fixed per Jie-F #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the KesslerGameGuide.pdf file to the repository root. Thi is a development guide intended to complement the scott_dick_controller.py file in the /examples directory.
File scott_dick_controller.py complements the KesslerGameGuide.pdf developer manual, which may be found in the repository root.
Adding KesslerGameGuide.pdf to repository root
Fixed aim bug as per reviewer Jie-F
Aim bug fix
Now in the right place
Is it in the right place YET?
Revert "Aim bug fix"
Updated KesslerGameGuide.pdf after fixing the aim bug per reviewer Jie-F.
|
LGTM. I think this would be a really valuable addition to the repo, great work! |
|
Cool, so is there any further action needed from me? Never actually
contributed to a project before.
Best regards,
Scott Dick
…On Wed, Nov 27, 2024 at 11:24 PM Jie-F ***@***.***> wrote:
LGTM. I think this would be a really valuable addition to the repo, great
work!
—
Reply to this email directly, view it on GitHub
<#74 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARAOZVYNVZZF3ZU4PAJOG32C2ZJ3AVCNFSM6AAAAABSUKF2PSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBVGM2DQNBTGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Dr. Scott Dick
Professor
Dept. of Electrical & Computer Engineering
University of Alberta
|
I think you're done! Tim's in charge of the repo, so when he gets around to it he may review and make a decision |
|
OK, thanks!
Best regards,
Scott Dick
…On Tue, Dec 3, 2024 at 2:04 PM Jie-F ***@***.***> wrote:
Cool, so is there any further action needed from me? Never actually
contributed to a project before. Best regards, Scott Dick
… <#m_-400123085396481353_>
On Wed, Nov 27, 2024 at 11:24 PM Jie-F *@*.*> wrote: LGTM. I think this
would be a really valuable addition to the repo, great work! — Reply to
this email directly, view it on GitHub <#74 (comment)
<#74 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AARAOZVYNVZZF3ZU4PAJOG32C2ZJ3AVCNFSM6AAAAABSUKF2PSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBVGM2DQNBTGE
<https://github.com/notifications/unsubscribe-auth/AARAOZVYNVZZF3ZU4PAJOG32C2ZJ3AVCNFSM6AAAAABSUKF2PSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBVGM2DQNBTGE>
. You are receiving this because you authored the thread.Message ID: @.*>
-- Dr. Scott Dick Professor Dept. of Electrical & Computer Engineering
University of Alberta
I think you're done! Tim's in charge of the repo, so when he gets around
to it he may review and make a decision
—
Reply to this email directly, view it on GitHub
<#74 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARAOZWIEE67KWUU5SGX3YT2DYMF7AVCNFSM6AAAAABSUKF2PSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJVGU2DONBVHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Dr. Scott Dick
Professor
Dept. of Electrical & Computer Engineering
University of Alberta
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim bug fixed and tested per reviewer comment from Jie-F. Developer guide also updated. This pull request supersedes the one from Nov. 26.