Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASCollectionElement] Add checks for nil element, prior to other PRs landing. #421

Merged
merged 1 commit into from
Jul 5, 2017

Conversation

appleguy
Copy link
Member

@appleguy appleguy commented Jul 5, 2017

No description provided.

@appleguy appleguy self-assigned this Jul 5, 2017
Copy link
Member

@Adlai-Holler Adlai-Holler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boom! Nice we're seeing this in production at Pinterest.

@Adlai-Holler
Copy link
Member

Merging before CI because we've really got to put a rush on this and the change is so safe.

@Adlai-Holler Adlai-Holler merged commit a68f3c5 into master Jul 5, 2017
@Adlai-Holler Adlai-Holler deleted the NilElement branch July 5, 2017 21:14
@ghost
Copy link

ghost commented Jul 5, 2017

1 Warning
⚠️ Any source code changes should have an entry in CHANGELOG.md or have #trivial in their title.

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants