Move Last Few Properties from ASTableView,ASCollectionView to Node #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 2, 2017 14:09
maicki
approved these changes
May 3, 2017
| return self.view.leadingScreensForBatching; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I guess the pending state would be another improvement we could build some kind of broader infrastructure around it.
nguyenhuy
approved these changes
May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ugh this is awful, I know.
But we should do this, and then immediately land another diff that removes a ton of this junk and makes those properties and the initializers for ASTableView/ASCollectionView unavailable. This is just an interim step.