Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Facebook from "Showcase" #1927

Closed
wants to merge 1 commit into from

Conversation

adamjernst
Copy link

The Facebook app no longer uses Texture.

Promote NYT to the first row and choose a random app from the last row to promote to the second row, so I don't have to rejigger the entire table.

The Facebook app no longer uses Texture.

Promote NYT to the first row and choose a random app from the last row to promote to the second row, so I don't have to rejigger the entire table.
@CLAassistant
Copy link

CLAassistant commented Oct 6, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@garrettmoon
Copy link
Member

@adamjernst Do you have a source that says FB no longer uses AsyncDisplayKit / Texture? Looks like it's still used as of January: https://www.appsight.io/app/facebook

@adamjernst
Copy link
Author

adamjernst commented Oct 6, 2020

@garrettmoon I am the source, as an employee. AsyncDisplayKit was removed from the Facebook app within the last few months. I can definitively say it is not used any more.

@adamjernst
Copy link
Author

Hey there @garrettmoon, just checking in to see if we can merge this to avoid confusion in the community. Thanks.

@adamjernst
Copy link
Author

Howdy folks, just checking in to see if we can merge this.

@garrettmoon
Copy link
Member

@adamjernst hey, sorry for the delay on this! I know it’s a pain, but can you resign the CLA and also take the time to rearrange the rest of the apps, not just promote a random app at the bottom?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants