-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for new iOS 13 traits #1568
Conversation
🚫 CI failed with log |
Note to reviewers: Blocked by Xcode 11 GM and CI upgrade. |
@nguyenhuy Xcode 11 GM is out now |
@ay8s - Hey just checking in on this since it'll be helpful for folks building for iOS 13. Can you rebase / resolve conflicts? |
@rahul-malik Away on a retreat this week so can take a look next week. Feel free to pick up if you need it sooner. |
@ay8s - Ping :) |
# Conflicts: # Source/Details/ASTraitCollection.h # Source/Details/ASTraitCollection.mm
FYI, I think this PR causes the podspec linting CI job to fail:
https://github.com/TextureGroup/Texture/runs/371568518 P/S: Perhaps we should run podspec lint on every pull request to catch issues earlier? Right now it's run on master only because the task is really slow. |
Good idea. I think it would be worth it. |
- UIUserInterfaceLevel was added to ASTraitCollection in TextureGroup#1568. However, it's unavailable on tvOS and thus broke our podspec linting CI job. Fix by only include it if the build target is iOS.
- UIUserInterfaceLevel was added to ASTraitCollection in #1568. However, it's unavailable on tvOS and thus broke our podspec linting CI job. Fix by only include it if the build target is iOS.
Adds userInterfaceLevel, accessibilityContrast and legibilityWeight available in iOS 13.
While looking into this I spotted that NSStringFromASPrimitiveTraitCollection (ASTraitCollection.mm) is inserting a nil value for preferredContentSizeCategory under iOS 13 when rotating a device. Similar to what we were seeing here... #754
We could create a AS_NSString method to handle it or check if it doesn't exist and just pass add UIContentSizeCategoryUnspecified.