Avoid dealloc on background #1394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 06e18a1.
|
is rebase reword enough to trigger test? => YES |
wsdwsd0829
force-pushed
the
fix-text-node-dealloc-on-bg
branch
from
251b8fb to
2b2c78b
Compare
|
Yes, should finish in about 2 hours. Yes, that’s our new build time after upgrading Xcode :( |
|
🚫 CI failed with log |
|
🚫 CI failed with log |
|
Agh, seems like a persistent CI issue. |
|
Can you rebase on master, this doesn't have the updated ./build.sh |
wsdwsd0829
force-pushed
the
fix-text-node-dealloc-on-bg
branch
from
2b2c78b to
c0c9980
Compare
|
🚫 CI failed with log |
|
🚫 CI failed with log |
* Fix isTruncated logic in ASTextNode2 * Add truncation tests
…ASCollectionViewCell (TextureGroup#1268)
* disable a11y cache * style update
* Introduce ASCellLayoutMode * Some smaller improvements * Improve logic around _superPerformBatchUpdates:completion: * Add comment about default values for ASCellLayoutModeNone * Always call _superReloadData:completion: within UICollectionView * Add initial range test for ASCellLayoutModeNone
* fix SIMULATE_WEB_RESPONSE not imported TextureGroup#449 * Fix to make rangeMode update in right time * remove uncessary assert * Fix collection cell editing bug for iOS 9 & 10 * Revert "Fix collection cell editing bug for iOS 9 & 10" This reverts commit 06e18a1. * Add description method for yoga. * Fix comment
If PIN_ANIMATED is enabled, the creation of a PINRemoteImageManager will create a sharedDownloader also. Thus we cannot assert that it doesn't exist. We will move this assertion up to the methods that create the preconfiguredSharedManager and before said manager is allocated.
…#1265) * Wrap supplementary node blocks to enable resizing them. Most ASCellNodeBlocks are wrapped by ASCollectionView.mm to add an `interactionDelegate` as well as calling `enterHierarchyState` on the node and setting its transform to a reflection if `inverted` is set on the collectionView. This PR adds this behavior to supplementary nodes as well. * Simplify code / block will never be nil
* fix SIMULATE_WEB_RESPONSE not imported TextureGroup#449 * Fix to make rangeMode update in right time * remove uncessary assert * Fix collection cell editing bug for iOS 9 & 10 * Revert "Fix collection cell editing bug for iOS 9 & 10" This reverts commit 06e18a1. * Add description method for yoga. * Fix comment
wsdwsd0829
force-pushed
the
fix-text-node-dealloc-on-bg
branch
from
29e494d to
e6e59e7
Compare
|
somehow messed up here, create a new one: #1410 |
Generated by 🚫 Danger |
|
🚫 CI failed with log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node can be deallocated on background and causing crash when it try to access view/gesture recognizers in dealloc.
ASMainThreadDeallocation.h should handle the ivar deallocation, thus we do not need to do it ourselves here