Yoga integration improvements #1187
Conversation
maicki
commented
Oct 23, 2018
maicki
commented
- Add thread safety for Yoga layout tree manipulation
- Support baseline alignments for ASYogaLayout
- Refactor ASLayoutElementYogaBaselineFunc to not require yogaParent (its parent style is set into a private var on ASLayoutElementStyle before layout instead)
- Only set the accessibility element to nil if the view is loaded
- Add nodeWillCalculateLayout callback to ASNodeController
There was a problem hiding this comment.
I'd like to get @appleguy 's take since he knows the Yoga integration the best but this is a pretty great diff!
Source/ASDisplayNode+Yoga.mm
Outdated
| - (ASDisplayNode *)yogaRoot { | ||
| ASDisplayNode *yogaRoot = self; | ||
| while(yogaRoot.yogaParent) { | ||
| yogaRoot = yogaRoot.yogaParent; |
There was a problem hiding this comment.
Can we avoid calling yogaParent twice per node?
There was a problem hiding this comment.
Yes, also a space after "while ("
Source/ASDisplayNode+Yoga.mm
Outdated
| node.yogaLayoutInProgress = YES; | ||
| if (node.yogaParent) { | ||
| node.style.parentAlignStyle = node.yogaParent.style.alignItems; |
There was a problem hiding this comment.
Avoid getting parent twice?
Source/ASDisplayNode+Beta.h
Outdated
| @@ -199,6 +199,7 @@ AS_EXTERN void ASDisplayNodePerformBlockOnEveryYogaChild(ASDisplayNode * _Nullab | |||
|
|
|||
| @property BOOL yogaLayoutInProgress; | |||
| @property (nullable, nonatomic) ASLayout *yogaCalculatedLayout; | |||
| @property (weak, readonly) ASDisplayNode *yogaRoot; | |||
There was a problem hiding this comment.
I might declare this a method, rather than an atomic weak property. Just to be more transparent.
Source/ASDisplayNode+Yoga.mm
Outdated
| - (ASDisplayNode *)yogaRoot { | ||
| ASDisplayNode *yogaRoot = self; | ||
| while(yogaRoot.yogaParent) { | ||
| yogaRoot = yogaRoot.yogaParent; |
There was a problem hiding this comment.
Yes, also a space after "while ("
| - (void)setYogaChildren:(NSArray *)yogaChildren | ||
| { | ||
| ASLockScope(self.yogaRoot); |
There was a problem hiding this comment.
Is this safe? Can't the yogaRoot be changing at this time? I'm pretty sure we also need to lock self, before accessing this and also hold that lock for the duration of the method for it to be re-entrant safe.
…ts parent style is set into a private var on ASLayoutElementStyle before layout instead)
maicki
force-pushed
the
MSYogaImprovements
branch
from
87f6e7e to
f90a74b
Compare
* Thread safety for Yoga layout * Support baseline alignments for ASYogaLayout * Refactor ASLayoutElementYogaBaselineFunc to not require yogaParent (its parent style is set into a private var on ASLayoutElementStyle before layout instead) * Only set the accessibility element if the view is loaded * Add nodeWillCalculateLayout to ASNodeController * Update Changelog * Address first comments
