Skip to content

Commit

Permalink
Don't return non-animated GIFs for animation (update to latest PINRem…
Browse files Browse the repository at this point in the history
…oteImage beta) (#940)

* Don't return non-animated GIFs for animation

* Update to latest PINRemoteImage beta
  • Loading branch information
garrettmoon authored Feb 21, 2019
1 parent efeb3d2 commit 999cb6e
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions Cartfile
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
github "pinterest/PINRemoteImage" "3.0.0-beta.13"
github "pinterest/PINCache" "3.0.1-beta.6"
github "pinterest/PINRemoteImage" "3.0.0-beta.14"
github "pinterest/PINCache" "3.0.1-beta.7"
2 changes: 1 addition & 1 deletion Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ target :'AsyncDisplayKitTests' do
pod 'JGMethodSwizzler', :git => 'https://github.com/JonasGessner/JGMethodSwizzler', :branch => 'master'

# Only for buck build
pod 'PINRemoteImage', '3.0.0-beta.13'
pod 'PINRemoteImage', '3.0.0-beta.14'
end

#TODO CocoaPods plugin instead?
Expand Down
2 changes: 1 addition & 1 deletion Source/Details/ASPINRemoteImageDownloader.mm
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ - (void)setPriority:(ASImageDownloaderPriority)priority withDownloadIdentifier:(
- (id)alternateRepresentationWithData:(NSData *)data options:(PINRemoteImageManagerDownloadOptions)options
{
#if PIN_ANIMATED_AVAILABLE
if ([data pin_isGIF]) {
if ([data pin_isAnimatedGIF]) {
return data;
}
#if PIN_WEBP_AVAILABLE
Expand Down
2 changes: 1 addition & 1 deletion Texture.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Pod::Spec.new do |spec|
end

spec.subspec 'PINRemoteImage' do |pin|
pin.dependency 'PINRemoteImage/iOS', '= 3.0.0-beta.13'
pin.dependency 'PINRemoteImage/iOS', '= 3.0.0-beta.14'
pin.dependency 'PINRemoteImage/PINCache'
pin.dependency 'Texture/Core'
end
Expand Down

0 comments on commit 999cb6e

Please sign in to comment.