ASDimensionMake to be more lenient #trivial (#382)

* ASDimensionMake to be more lenient Don't throw assertion when the string is invalid * Fix unit test
TextureGroup · Jun 30, 2017 · 7dce481 · 7dce481
1 parent 928bc9f
commit 7dce481
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/Source/Layout/ASDimension.mm b/Source/Layout/ASDimension.mm
@@ -47,7 +47,6 @@ ASOVERLOADABLE ASDimension ASDimensionMake(NSString *dimension)
     }
   }
 
-  ASDisplayNodeCAssert(NO, @"Parsing dimension failed for: %@", dimension);
   return ASDimensionAuto;
 }
 

diff --git a/Tests/ASDimensionTests.mm b/Tests/ASDimensionTests.mm
@@ -29,7 +29,7 @@ - (void)testCreatingDimensionUnitAutos
 {
   XCTAssertNoThrow(ASDimensionMake(ASDimensionUnitAuto, 0));
   XCTAssertThrows(ASDimensionMake(ASDimensionUnitAuto, 100));
-  XCTAssertThrows(ASDimensionMake(@""));
+  ASXCTAssertEqualDimensions(ASDimensionAuto, ASDimensionMake(@""));
   ASXCTAssertEqualDimensions(ASDimensionAuto, ASDimensionMake(@"auto"));
 }
-Original file line number
+Diff line change
@@ Expand Up @@
         }
       }
-      ASDisplayNodeCAssert(NO, @"Parsing dimension failed for: %@", dimension);
       return ASDimensionAuto;
     }
@@ Expand Down @@