use lock to avoid crash when image might be changed during the trait …

…collection change (#1651)
TextureGroup · Aug 30, 2019 · 4d6532c · 4d6532c
1 parent 0cd5561
commit 4d6532c
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/Source/ASImageNode.mm b/Source/ASImageNode.mm
@@ -756,6 +756,7 @@ - (void)asyncTraitCollectionDidChangeWithPreviousTraitCollection:(ASPrimitiveTra
   [super asyncTraitCollectionDidChangeWithPreviousTraitCollection:previousTraitCollection];
 
   if (AS_AVAILABLE_IOS_TVOS(12, 10)) {
+    __instanceLock__.lock();
       // update image if userInterfaceStyle was changed (dark mode)
       if (_image != nil && self.primitiveTraitCollection.userInterfaceStyle != previousTraitCollection.userInterfaceStyle) {
           UITraitCollection *tc = [UITraitCollection traitCollectionWithUserInterfaceStyle:self.primitiveTraitCollection.userInterfaceStyle];
@@ -764,9 +765,8 @@ - (void)asyncTraitCollectionDidChangeWithPreviousTraitCollection:(ASPrimitiveTra
           if ( updatedImage != nil ) {
               _image = updatedImage;
           }
-        // trigger needs display anyway, cause image might be dynamic itself (e.g. dynamic tint color)
-        [self setNeedsDisplay];
       }
+    __instanceLock__.unlock();
   }
 }