Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bindings as tuples #962

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Fix bindings as tuples #962

merged 1 commit into from
Oct 19, 2022

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Oct 19, 2022 •
edited
Loading

The logic for splitting keys was only being applied to Binding when supplied as the dataclass, not when the tuple was used.

davep
davep approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@davep davep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@willmcgugan willmcgugan merged commit b18842b into css Oct 19, 2022
@willmcgugan willmcgugan deleted the binding-tuple-fix branch October 19, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

@davep davep davep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darrenburns @davep @willmcgugan