Review the use of the bell in various examples and documentation files #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't ping the terminal bell on every key-press. This might be okay on some systems, on others (we're looking at you Windows) it's a wee bit distracting. See Textualize#955.
While in this part of the docs we do want to keep the bell (see key02), it was an error in the code that it included this event in key01. Removing it from here because adding this bit of code for key02 is a key (no pun) part of the docs.
It doesn't appear to be referenced anywhere in the docs.
It doesn't appear to be referenced anywhere in the docs.
Not an issue with removing the bell, actually a pre-existing mistake in the docs. The wrong file was being included.
Originally it was partially correct in that it did sound the bell, but it also then exited the application and printed the details of the button -- the text didn't mention the latter aspect. This corrects that and removes mention of the bell sound because we've now removed that.
darrenburns
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of a read-through and review of documentation and example files, looking for instances of
App.bellbeing used.See #955.