Try and better settle focus after a focused widget is removed #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that, for example, the widget remains in the Screen.focus_chain so that it's easier to handle passing off focus on removal. To help address Textualize#939.
Rather than call on Screen._reset_focus, which seems to only really consider siblings, instead call on the being-removed widget's screen to find the previous widget that can receive focus. Addresses Textualize#939.
Added to allow checking where focus can and should go without actually causing focus to move. Initially added to aid resolve Textualize#943. Also mote that Screen._move_focus has been rewritten to use Screen.focus_from (really the bulk of Screen.focus_from was taken from Screen._move_focus).
In aid of resolving Textualize#943.
davep
commented
Oct 18, 2022
| remove_widgets = widget.walk_children( | ||
| Widget, with_self=True, method="depth", reverse=True | ||
| # Get the list of all the widgets that are about to be removed. | ||
| remove_widgets = list( |
There was a problem hiding this comment.
Note I've note made the suggested change to walk_children here (have it return a list) -- I didn't want to head off into a side-quest while working on this. If we're happy with this particular PR I'll then go tweak walk_children and come back and tidy this up.
|
Closed in preference to #954 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeks to resolve #939.