Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some bug fixes in Input + add title to App constructor #934

Merged
merged 3 commits into from
Oct 17, 2022

Conversation

darrenburns
Copy link
Member

  • Adds argument to App allowing you to set App.title via the constructor
  • Two Input.Changed events were being sent on initialisation of Input widget. This event will now only be sent if a non-None value is set using the constructor. (Signature of Input init changed slightly - value is now Optional.)
  • The validator for view_position was being called on every re-render (self.view_position = self.view_position). I'm not sure why this was the case - but the validator is immediately called anyway via watch_cursor_position. Is there some situation where view position can change NOT as a result of cursor position that I'm not thinking of?

@willmcgugan willmcgugan merged commit 73e698d into css Oct 17, 2022
@willmcgugan willmcgugan deleted the app-title-constructor branch October 17, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants