Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depth first search #902

Merged
merged 5 commits into from
Oct 14, 2022
Merged

depth first search #902

merged 5 commits into from
Oct 14, 2022

Conversation

willmcgugan
Copy link
Collaborator

Adds a depth-first walk of the DOM.

Fixes removing an exception when removing a widget in the stopwatch example.

davep
davep previously approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@davep davep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the first time I've seen Literal in the wild. :-)

@willmcgugan
Copy link
Collaborator Author

I am literally a fan.

@willmcgugan willmcgugan dismissed davep’s stale review October 13, 2022 20:05

Made some significant changes

darrenburns
darrenburns approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@darrenburns darrenburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@willmcgugan willmcgugan merged commit ef7ecc0 into css Oct 14, 2022
@willmcgugan willmcgugan deleted the depth-first branch October 14, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrenburns darrenburns darrenburns approved these changes

@davep davep davep left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willmcgugan @davep @darrenburns