Modify the screen examples to import Screen from textual.screen #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The surrounding text in the documentation states that Screen is imported from textual.screen, but the code was importing the class from textual.app. Further, I was getting warnings from pyright that I was using a class that wasn't exported from the module I was importing from.
willmcgugan
previously approved these changes
Oct 13, 2022
|
@davep Just noticed this will break the code highlghting feature in the docs. If you search for those files in the docs (.md files), you will find those examples there. You will need to update the "hl_lines" attribute accordingly. You can run |
I'd not realised that Textualize@78ea2cd would have a visible knock-on effect in the docs, because the docs specify which lines should be highlighted. As per this comment Textualize#888 (comment) this corrects that.
|
Thanks for pointing that out @willmcgugan -- now hopefully corrected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The surrounding text in the documentation states that Screen is imported from textual.screen, but the code was importing the class from textual.app. Further, I was getting warnings from pyright that I was using a class that wasn't exported from the module I was importing from.