Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme #758

Merged
merged 24 commits into from
Sep 13, 2022
Merged

Readme #758

merged 24 commits into from
Sep 13, 2022

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented Sep 10, 2022

  • Update to the README.
  • Updates the screenshot action to accept both a path and a file, and a time format.

In a later update I'll add a small example app.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@@ -566,22 +567,32 @@ def export_screenshot(self, *, title: str | None = None) -> str:
console.print(screen_render)
return console.export_svg(title=title or self.title)

def save_screenshot(self, path: str | None = None) -> str:
"""Save a screenshot of the current screen.
def save_screenshot(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could note this down to mention as a HOWTO.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saving screenshots? Feels a bit too trivial for a how-to, as long as it appears in the search...

src/textual/app.py Outdated Show resolved Hide resolved
src/textual/app.py Show resolved Hide resolved
src/textual/app.py Outdated Show resolved Hide resolved
src/textual/app.py Show resolved Hide resolved
@willmcgugan willmcgugan merged commit 3ba9203 into css Sep 13, 2022
@willmcgugan willmcgugan deleted the readme branch September 13, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants