tree fix #744
Merged
tree fix #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmcgugan
commented
Sep 7, 2022
| if key_method is not None: | ||
| if await invoke(key_method, event): | ||
| event.prevent_default() | ||
| await invoke(key_method, event) |
There was a problem hiding this comment.
Sight change in semantics here. If there is a key_ method defined for a given key then it won't attempt to try the base classes.
willmcgugan
commented
Sep 7, 2022
src/textual/widget.py
Outdated
| @@ -1080,7 +1093,7 @@ def scroll_to_region( | |||
| self.scroll_relative( | |||
| delta.x or None, | |||
| delta.y or None, | |||
| animate=animate, | |||
| animate=animate if abs(delta_y) > 1 else False, | |||
There was a problem hiding this comment.
Don't animate movement of a single line.
darrenburns
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2022-09-07.at.15.13.45.mov